gh-92888: memory_ass_sub() calls CHECK_RELEASED_INT() twice #93127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a memoryview is released while setting an item, raise an exception. For example, converting an object to an index in C can execute arbitrary Python code which can indirectly release the memoryview.
|
I chose to keep the CHECK_RELEASED_INT() call at memory_ass_sub() entry. I guess that memory_subscript() suffers from the same issue: I would prefer to fix it in a separated PR, but maybe then we can combine the two changes when backporting to stable branches. |
|
PR #92946 seems more complete, I close my issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a memoryview is released while setting an item, raise an
exception. For example, converting an object to an index in C can
execute arbitrary Python code which can indirectly release the
memoryview.